Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6523471f-aaf2-4f26-87b0-d9889079c81c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ankane as discussed in #59 (comment), this creates a new version of Pgvector.EntityFrameworkCore which targets net10.0 (and EF10) instead of the previous net9.0 (and EF9). The reason for doing this is that net9.0/EF9 are about to go out of support, and targeting net9.0 will start emitting warnings.
I'm proposing to bump the version of Pgvector.EntityFrameworkCore from 0.3.0 to 10.0.0, to align the library's versioning it with the EF's version (as most providers/extensions do) - but if you prefer something else (e.g. 0.4.0) let me know and I'll do that instead.
I will also submit a 2nd PR stacked upon this which bumps yet again, and targets net11.0 and (the upcoming) EF11. This is specifically required for #59, which stops loading vector columns by default (quite important for perf).
Let me know what you think and if you have any concerns, am happy to change things as needed.
Summary
Pgvector.EntityFrameworkCoreto version10.0.0, target onlynet10.0, and reference stableNpgsql.EntityFrameworkCore.PostgreSQL10.0.3.build/net10.0and update compatibility documentation and the changelog.PgvectorandPgvector.Dapperpackage versions, targets, and dependency policies unchanged.This is the bottom layer of a planned two-PR chain. The EF 11 release and
IsAutoLoadedconvention belong to the follow-up PR; this PR does not complete #59. The package version numbering follows the proposed release plan and is not a claim of maintainer approval.Validation
lib/net10.0,build/net10.0, package version10.0.0, and the10.0.3provider dependency.net10.0project consumed the packed package successfully and generated the expected design-time services attribute.